From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Apply panel_bridge helper Date: Sun, 22 Mar 2026 04:35:49 +1000 Message-ID: In-Reply-To: <20260319074744.1965918-4-damon.ding@rock-chips.com> References: <20260319071452.1961274-1-damon.ding@rock-chips.com> <20260319074744.1965918-4-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Converts the panel to a panel_bridge, eliminating all direct `drm_panel_*` calls from the analogix_dp core. This is the final cleanup. **BUG**: In the error path for `devm_drm_panel_bridge_add()`: ```c dp->plat_data->next_bridge = devm_drm_panel_bridge_add(dp->dev, dp->plat_data->panel); if (IS_ERR(dp->plat_data->next_bridge)) { ret = PTR_ERR(bridge); // <-- BUG: should be PTR_ERR(dp->plat_data->next_bridge) goto err_unregister_aux; } ``` `bridge` is `&dp->bridge` which is a valid pointer at this point, so `PTR_ERR(bridge)` will return a garbage/wrong error code. This should be `PTR_ERR(dp->plat_data->next_bridge)`. **Note on mbox ordering**: Patches 14-17 were sent as a separate sub-thread (different Message-Id base `20260319074744.1965918`), likely a resend to fix something. The logical ordering in the cover letter is respected but the mbox has some patches arriving out of numerical order (e.g., 10 before 08, 13 before 09). This is cosmetic but may confuse tooling. --- **Summary**: The series is well-structured and mostly correct. The one real bug is the `PTR_ERR(bridge)` vs `PTR_ERR(dp->plat_data->next_bridge)` in patch 17 which must be fixed before merging. --- Generated by Claude Code Patch Reviewer