From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Add member to intel_dp to store AS SDP v2 support Date: Sun, 12 Apr 2026 12:51:28 +1000 Message-ID: In-Reply-To: <20260408084239.1295325-18-ankit.k.nautiyal@intel.com> References: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com> <20260408084239.1295325-18-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `as_sdp_v2_supported` to `struct intel_dp` and populates it during detect via `intel_dp_detect_sdp_caps()`. The detection logic: - For eDP: always v2 (per eDP v1.5a) - For DP: infer from FAVT payload fields parsing or from async video timing not supported in PR The comment block is thorough. One minor style issue -- double space: ```c intel_dp->as_sdp_v2_supported = true; ``` Missing R-b. --- Generated by Claude Code Patch Reviewer