From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: ilitek-ili9881c: support Waveshare 7.0" DSI panel Date: Sun, 12 Apr 2026 09:06:57 +1000 Message-ID: In-Reply-To: <20260411-waveshare-dsi-touch-v2-17-75cdbeac5156@oss.qualcomm.com> References: <20260411-waveshare-dsi-touch-v2-0-75cdbeac5156@oss.qualcomm.com> <20260411-waveshare-dsi-touch-v2-17-75cdbeac5156@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds Waveshare 7.0" panel support with iovcc regulator. **`devm_regulator_get_optional()` misuse**: The code treats any error (including `-ENODEV`) as fatal: ```c ctx->iovcc = devm_regulator_get_optional(&dsi->dev, "iovcc"); if (IS_ERR(ctx->iovcc)) return dev_err_probe(&dsi->dev, PTR_ERR(ctx->iovcc), ...); ``` But then guards usage with `if (ctx->iovcc)`, implying it should be optional. Either handle `-ENODEV` by setting `ctx->iovcc = NULL`, or use `devm_regulator_get()` if the supply is truly required for this panel. --- --- Generated by Claude Code Patch Reviewer