From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: phy: introduce phy_get_max_link_rate() helper for consumers Date: Tue, 05 May 2026 10:35:05 +1000 Message-ID: In-Reply-To: <20260430110652.558622-18-vladimir.oltean@nxp.com> References: <20260430110652.558622-1-vladimir.oltean@nxp.com> <20260430110652.558622-18-vladimir.oltean@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds a new exported function to replace `phy->attrs.max_link_rate` access. Used by DRM bridge drivers (cdns-mhdp8546, dw-dp) and CAN drivers (at91_can, flexcan, m_can, rcar_canfd). For CAN drivers, the transceiver is optional (NULL), so the NULL tolerance allows simplifying: ```c // Before: if (transceiver) priv->can.bitrate_max = transceiver->attrs.max_link_rate; // After: priv->can.bitrate_max = phy_get_max_link_rate(transceiver); ``` Acked-by: Markus Schneider-Pargmann. Clean improvement. --- Generated by Claude Code Patch Reviewer