From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Merge top and bottom half IRQ handlers Date: Tue, 05 May 2026 07:58:58 +1000 Message-ID: In-Reply-To: <20260504191059.275928-18-jonas@kwiboo.se> References: <20260504191059.275928-1-jonas@kwiboo.se> <20260504191059.275928-18-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review With HPD handling moved to `delayed_work`, the bottom half (threaded IRQ) o= nly calls `mod_delayed_work()`, which is safe from hardirq context. The two= handlers are merged into a single hardirq handler, and `devm_request_threa= ded_irq()` is replaced with `devm_request_irq()`. ```c + intr_stat =3D hdmi_readb(hdmi, HDMI_IH_PHY_STAT0) & HDMI_IH_PHY_STAT0_HPD; if (intr_stat) { + hdmi_writeb(hdmi, ~0, HDMI_IH_MUTE_PHY_STAT0); ``` The muting (`~0` to MUTE register) followed by unmuting (`~HDMI_IH_PHY_STAT= 0_HPD`) within the same handler is correct =E2=80=94 it prevents re-entry w= hile the handler processes the interrupt. The `mod_delayed_work()` document= ation confirms it is safe in atomic context. One small note: the register reads and writes within the hardirq handler us= e `regmap_write`/`regmap_read` underneath (via `hdmi_writeb`/`hdmi_readb`).= If the regmap uses a bus that can sleep (e.g., I2C), this would be problem= atic in hardirq context. However, dw-hdmi uses MMIO regmap, so this is fine= . **No Reviewed-by yet.** **Summary**: The series is well-decomposed and correct. The new v4 patches = (12-17) are the ones that need review attention. The main risk area is patc= h 14's removal of RXSENSE handling, which changes the HPD detection behavio= r to be purely HPD-based with debouncing. This should work well for HDMI 1.= 4+ sinks but could potentially affect edge cases with older or non-complian= t sinks that rely on RXSENSE for detection. The cover letter notes testing = was done on Rockchip RK3328/RK3399/RK3568, and requests more testing with b= ridge connector users. --- Generated by Claude Code Patch Reviewer