From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Rework HDP and RXSENSE interrupt handling Date: Sat, 16 May 2026 16:21:45 +1000 Message-ID: In-Reply-To: <20260510124111.1226584-18-jonas@kwiboo.se> References: <20260510124111.1226584-1-jonas@kwiboo.se> <20260510124111.1226584-18-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The biggest behavioral change: completely removes RXSENSE interrupt handling. The rationale is that the debounced delayed_work (patch 16) now handles the EDID-change pulse case that RXSENSE was originally designed for. Key changes: - Only HPD interrupts are enabled/unmasked (not RX_SENSE) - `force`, `disabled`, `rxsense`, `phy_mask` fields removed from `struct dw_hdmi` - `dw_hdmi_update_phy_mask()` removed - Initial HPD polarity set based on current HPD pin status (avoids spurious initial interrupt) The IRQ handler simplifies nicely. `dw_hdmi_phy_update_hpd()` and `dw_hdmi_setup_rx_sense()` are gutted (made empty), to be removed in patches 18-19. **One consideration**: platforms using custom PHY ops with their own `update_hpd` implementations may have relied on the RXSENSE masking. However, examining the tree, all in-tree implementations (synopsys, rockchip, imx8mp, sun4i) use the stock `dw_hdmi_phy_update_hpd` which this series empties. So this is safe. --- Generated by Claude Code Patch Reviewer