From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dyndbg: macrofy a 2-index for-loop pattern Date: Thu, 04 Jun 2026 14:06:59 +1000 Message-ID: In-Reply-To: <20260601-dd-maint-2-v3-17-4a15b241bd3c@gmail.com> References: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com> <20260601-dd-maint-2-v3-17-4a15b241bd3c@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The `for_subvec` macro is somewhat unusual -- it expects caller-declared variables `i` and a pointer, and uses token pasting for `num_##_vec`. The naming convention dependency makes it fragile if struct members are renamed. This is partially addressed in patch 19 which changes the paste to `.len`. The comment `/* { block } */` is a nice reminder of usage. No major issues, though the macro could be considered over-engineering for just 2 use sites. --- Generated by Claude Code Patch Reviewer