From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: MAINTAINERS: Add MAINTAINERS entry for QDA driver Date: Tue, 24 Feb 2026 18:20:14 +1000 Message-ID: In-Reply-To: <20260224-qda-firstpost-v1-18-fe46a9c1a046@oss.qualcomm.com> References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> <20260224-qda-firstpost-v1-18-fe46a9c1a046@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review - Should be in patch 1 per Dmitry. --- **Summary of required changes before resubmission:** 1. Resolve the userspace ABI compatibility story =E2=80=94 how do existing = `/dev/fastrpc-*` applications keep working? 2. Rename from "QDA" to something meaningful (e.g., `fastrpc_accel`) 3. Move DRM device allocation to the first patch; use `devm_drm_dev_alloc()` 4. Replace custom logging macros with `drm_err()`/`drm_dbg()` 5. Use `drm_gem_dma_helper` instead of custom GEM DMA implementation 6. Fix the `__user` pointer security issue in FastRPC invocation 7. Fix UAPI structure layouts (remove unnecessary padding) 8. Remove impossible NULL checks and excessive debug prints 9. Squash early patches to create reviewable, functional units 10. Address the IOMMU bus type approach with IOMMU maintainers 11. Fix 270 kernel-doc warnings --- Generated by Claude Code Patch Reviewer