From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Split AS SDP computation between compute_config and compute_config_late Date: Tue, 31 Mar 2026 17:39:49 +1000 Message-ID: In-Reply-To: <20260330040656.4116502-19-ankit.k.nautiyal@intel.com> References: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> <20260330040656.4116502-19-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good architectural split. The early phase (`intel_dp_compute_as_sdp`) sets only the infoframe enable bit so guardband can account for it. The late phase (`intel_dp_as_sdp_compute_config_late`) fills in the actual SDP fields after other features are resolved. The check using bitwise AND needs parentheses for clarity (though it works correctly due to `== 0` precedence): ```c + if ((crtc_state->infoframes.enable & + intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC)) == 0) ``` This is fine. No R-b tag. --- Generated by Claude Code Patch Reviewer