From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: mm: Add BAR1 user interface Date: Tue, 28 Apr 2026 15:32:03 +1000 Message-ID: In-Reply-To: <20260425211454.174696-19-joelagnelf@nvidia.com> References: <20260425211454.174696-1-joelagnelf@nvidia.com> <20260425211454.174696-19-joelagnelf@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Introduces `BarUser` and `BarUserAccess` for mapping physical pages into BA= R1. Clean RAII design. **Minor =E2=80=94 `BarUserAccess::drop` uses `pr_warn_once!`:** Only the fi= rst unmap failure is ever reported. For a resource leak, `pr_warn!` (withou= t `_once`) would be more appropriate. **Minor =E2=80=94 `mapped()` unwrap:** The `.unwrap()` in `mapped()` is saf= e by construction (never called from Drop), but `expect("BarUserAccess: map= ped range consumed before access")` would provide a better panic message if= violated. --- Generated by Claude Code Patch Reviewer