From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: pci: make Bar lifetime-parameterized
Date: Tue, 28 Apr 2026 13:47:58 +1000
Message-ID: <review-patch18-20260427221155.2144848-19-dakr@kernel.org>
In-Reply-To: <20260427221155.2144848-19-dakr@kernel.org>
References: <20260427221155.2144848-1-dakr@kernel.org> <20260427221155.2144848-19-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

`Bar<SIZE>` becomes `Bar<'a, SIZE>` storing `&'a Device<Bound>` instead of `ARef<Device>`. The `into_devres()` method:
```rust
pub fn into_devres(self) -> Result<Devres<Bar<'static, SIZE>>> {
    let bar: Bar<'static, SIZE> = unsafe { core::mem::transmute(self) };
    let pdev = bar.pdev;
    Devres::new(pdev.as_ref(), bar)
}
```
The lifetime erasure to `'static` is sound because `Devres` revokes access on unbind. Note that after transmute, `bar.pdev` is used to get the device reference for `Devres::new` -- this works because the device pointer itself remains valid.

The return type change from `impl PinInit<Devres<Bar<SIZE>>, Error>` to `Result<Bar<'a, SIZE>>` is a clean simplification.

---
Generated by Claude Code Patch Reviewer