From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized Date: Mon, 25 May 2026 19:29:14 +1000 Message-ID: In-Reply-To: <20260521233501.1191842-19-dakr@kernel.org> References: <20260521233501.1191842-1-dakr@kernel.org> <20260521233501.1191842-19-dakr@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Mirrors patch 17 for IoMem/ExclusiveIoMem. Same pattern: stores `&'a Device`, returns direct `Result>`, provides `into_devres()` with the same transmute-to-`'static` pattern. The tyr driver and pwm_th1520 driver are updated to use the new API. The pwm driver's usage is interesting: ```rust iomem <- request.iomap_sized::()?.into_devres(), ``` The `<-` pin-init syntax with the chained `?` and `.into_devres()` works because `into_devres()` returns `Result>` which implements `PinInit`. No issues. --- --- Generated by Claude Code Patch Reviewer