From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Date: Mon, 25 May 2026 17:26:12 +1000 Message-ID: In-Reply-To: <20260523-color-format-v16-18-24340c5e4732@collabora.com> References: <20260523-color-format-v16-0-24340c5e4732@collabora.com> <20260523-color-format-v16-18-24340c5e4732@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The per-connector output mode selection for RK3576 is necessary because the= hardware uses different register values for DP vs HDMI YUV422. The `drm_er= r` + `return` for unknown connector types is appropriate. **Minor:** The `vop2_unlock(vop2)` before `return` in the error path looks = correct, but it's worth verifying that the lock is held at this point =E2= =80=94 which it is, as this code is inside the `vop2_lock/vop2_unlock` scop= e of `vop2_crtc_atomic_enable`. No issues. --- Generated by Claude Code Patch Reviewer