From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tidss: Convert to atomic_create_state Date: Wed, 27 May 2026 14:30:52 +1000 Message-ID: In-Reply-To: <20260526-drm-mode-config-init-v6-18-852346394200@kernel.org> References: <20260526-drm-mode-config-init-v6-0-852346394200@kernel.org> <20260526-drm-mode-config-init-v6-18-852346394200@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Converts tidss CRTC from `reset` to `atomic_create_state`. The old `tidss_c= rtc_reset()` destroyed old state, allocated new, and called `__drm_atomic_h= elper_crtc_reset()`. The new `tidss_crtc_create_state()` just allocates and= initializes =E2=80=94 no state pointer assignment, no old state destructio= n. This is correct for the `atomic_create_state` contract. Also switches the plane from `drm_atomic_helper_plane_reset` to `drm_atomic= _helper_plane_create_state`. Clean. Note: The `.reset` callback is removed entirely. This means `drm_mode_confi= g_reset()` (used during suspend/resume) will fall back to the `else if (ato= mic_create_state)` path in the modified `drm_mode_config_reset()` from patc= h 10/12. This is correct behavior =E2=80=94 the `reset_with_create_state` h= elper properly destroys old state and creates new. --- Generated by Claude Code Patch Reviewer