From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dyndbg: Upgrade class param storage to u64 for 64-bit classmaps Date: Thu, 04 Jun 2026 12:12:50 +1000 Message-ID: In-Reply-To: <20260602-dd-maint-2-v4-18-19a1445585a8@gmail.com> References: <20260602-dd-maint-2-v4-0-19a1445585a8@gmail.com> <20260602-dd-maint-2-v4-18-19a1445585a8@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Issue (minor):** The `CLASSMAP_BITMASK` macro: ```c #define CLASSMAP_BITMASK(width) ((width) == 64 ? ~0ULL : (1ULL << (width)) - 1) ``` has a potential operator precedence issue: `(1ULL << (width)) - 1` should be `((1ULL << (width)) - 1)` to be safe in all expression contexts. While in the current call sites the result is used directly or with `&`, it's defensive to add the parens. The DRM changes are correct: `__drm_debug` changes from `unsigned long` to `u64`, and the module_param changes from `ulong` to `ullong`. The `test_bit()` to `!!(val & (1ULL << bi))` conversions are correct. The `param_get_dyndbg_classes` change for `DD_CLASS_TYPE_LEVEL_NUM` uses `%llu` format for a `u64` value that was previously `unsigned int *lvl` -- this is correct after the type change. --- Generated by Claude Code Patch Reviewer