From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Always enable AS SDP if supported by source + sink Date: Thu, 12 Mar 2026 06:55:32 +1000 Message-ID: In-Reply-To: <20260311113611.3393194-20-ankit.k.nautiyal@intel.com> References: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com> <20260311113611.3393194-20-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Changes `intel_dp_can_use_as_sdp()` to return `true` whenever AS SDP is supported (regardless of VRR), removing the `crtc_state->vrr.enable` check. This is the culmination of the series. Combined with the split compute phases (patch 17), the late compute will determine the actual SDP fields based on which features are active. **This looks correct** given the preparatory work, though it means AS SDP will be sent even on configurations where no VRR/PR/CMRR feature needs it (just with AVT_FIXED_VTOTAL mode). --- Generated by Claude Code Patch Reviewer