From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Always enable AS SDP if supported by source + sink Date: Tue, 31 Mar 2026 17:39:49 +1000 Message-ID: In-Reply-To: <20260330040656.4116502-20-ankit.k.nautiyal@intel.com> References: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> <20260330040656.4116502-20-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Changes `intel_dp_can_use_as_sdp()` to return `true` whenever source + sink= support it (removing the `vrr.enable` requirement). This is the payoff for= the entire series =E2=80=94 AS SDP is always active so it's available for = PR, CMRR, etc. without triggering modesets. Combined with patch 18's late computation, the `mode` field will correctly = be set to `DP_AS_SDP_AVT_FIXED_VTOTAL` when neither VRR nor CMRR is enabled= . No R-b tag but the change itself is trivial. --- **Summary of items needing attention:** 1. **Patch 12 (bug):** `drm_dp_dpcd_read_byte()` returns 0 on success, not = 1 =E2=80=94 AS SDP v2 detection is broken. 2. **Patch 4 + 15 (inconsistency):** PANEL_REPLAY_CONFIG3 at 0x11a vs burst= write to 0x1b0+2=3D0x1b2 =E2=80=94 one of these is wrong. 3. **Patch 7:** Removing `assume_all_enabled` for AS SDP guardband could ca= use issues between patches 7 and 19. --- Generated by Claude Code Patch Reviewer