From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: samples: rust: rust_driver_pci: use HRT lifetime for Bar
Date: Thu, 07 May 2026 13:02:05 +1000
Message-ID: <review-patch19-20260506215113.851360-20-dakr@kernel.org>
In-Reply-To: <20260506215113.851360-20-dakr@kernel.org>
References: <20260506215113.851360-1-dakr@kernel.org> <20260506215113.851360-20-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

This demonstrates the end-state ergonomics beautifully:
```rust
struct SampleDriver<'bound> {
    pdev: &'bound pci::Device,
    bar: Bar0<'bound>,
    index: TestIndex,
}
```

Gone: `#[pin_data(PinnedDrop)]`, `ARef<pci::Device>`, `Devres<Bar0>`, `pin_init_scope`, `bar.access(pdev.as_ref())?`. The driver is dramatically simpler.

The `Drop` impl replaces `PinnedDrop`, which is correct since the struct no longer needs pinning (no `#[pin]` fields).

No issues found.

### PATCHES 20-21: rename 'a lifetime to 'bound

Pure cosmetic rename for consistency. Makes the codebase read clearly -- `'bound` immediately conveys "device binding scope."

No issues found.

---
Generated by Claude Code Patch Reviewer