From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tidss: Convert to atomic_create_state Date: Sat, 16 May 2026 13:22:56 +1000 Message-ID: In-Reply-To: <20260512-drm-mode-config-init-v4-19-591dfdcc1bf9@kernel.org> References: <20260512-drm-mode-config-init-v4-0-591dfdcc1bf9@kernel.org> <20260512-drm-mode-config-init-v4-19-591dfdcc1bf9@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Converts tidss CRTC from `reset` to `atomic_create_state` =E2=80=94 the old= `tidss_crtc_reset` only allocated state (no HW reset), so this is a direct= equivalent. Also switches plane to `drm_atomic_helper_plane_create_state`. The conversion correctly: - Returns `ERR_PTR(-ENOMEM)` instead of silently setting `crtc->state =3D N= ULL` - Uses `__drm_atomic_helper_crtc_state_init()` instead of `__drm_atomic_hel= per_crtc_reset()` - Does NOT assign `crtc->state` (that's the caller's job) No issues. --- Generated by Claude Code Patch Reviewer