From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Rework HDP and RXSENSE interrupt handling Date: Mon, 18 May 2026 16:41:49 +1000 Message-ID: In-Reply-To: <20260516183838.2024991-20-jonas@kwiboo.se> References: <20260516183838.2024991-1-jonas@kwiboo.se> <20260516183838.2024991-20-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status:** Major cleanup, looks correct. Removes all RXSENSE handling. The `dw_hdmi_phy_update_hpd()` and `dw_hdmi_setup_rx_sense()` bodies are emptied (will be removed in patches 20-21). The IRQ handler is dramatically simplified to only handle HPD: ```c + hdmi_modb(hdmi, hdmi_readb(hdmi, HDMI_PHY_STAT0) & HDMI_PHY_HPD ? + 0 : HDMI_PHY_HPD, HDMI_PHY_HPD, HDMI_PHY_POL0); ``` The initial HPD polarity is set based on current HPD status in `dw_hdmi_phy_setup_hpd()`, which avoids a spurious interrupt at probe/resume. Good change. Removes several state variables: `force`, `disabled`, `rxsense`, `phy_mask`. --- Generated by Claude Code Patch Reviewer