From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/mdss: use new helper to set amsbc Date: Mon, 25 May 2026 21:42:00 +1000 Message-ID: In-Reply-To: <20260520-ubwc-rework-v5-19-72f2749bc807@oss.qualcomm.com> References: <20260520-ubwc-rework-v5-0-72f2749bc807@oss.qualcomm.com> <20260520-ubwc-rework-v5-19-72f2749bc807@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review ```c - if (data->ubwc_enc_version == UBWC_3_0) + if (qcom_ubwc_enable_amsbc(data)) value |= MDSS_UBWC_STATIC_UBWC_AMSBC; ``` **Note:** This changes behavior -- the old code only set AMSBC for exactly UBWC_3_0 in the MDSS `5x_setup_ubwc` path. The helper returns `>= UBWC_3_0`, which would include UBWC_4_0+ if such SoCs ever used the 5x setup path. This is correct because the 5x setup path is only used by older SoCs, and the change aligns it with how GPU drivers already treat amsbc. --- Generated by Claude Code Patch Reviewer