From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: samples: rust: rust_driver_pci: use HRT lifetime for Bar
Date: Mon, 25 May 2026 19:29:15 +1000
Message-ID: <review-patch19-20260521233501.1191842-20-dakr@kernel.org>
In-Reply-To: <20260521233501.1191842-20-dakr@kernel.org>
References: <20260521233501.1191842-1-dakr@kernel.org> <20260521233501.1191842-20-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Showcases the ergonomic improvement. The sample driver splits into `SampleD=
river` (zero-sized driver type) and `SampleDriverData<'bound>`:

```rust
struct SampleDriverData<'bound> {
    pdev: &'bound pci::Device,
    bar: Bar0<'bound>,
}
```

Direct `self.bar.read32(OFFSET)` access, no `Devres::access()` needed. The =
`PinnedDrop` implementation is removed entirely =E2=80=94 the compiler-enfo=
rced lifetime makes it unnecessary.

Good demonstration of the HRT value proposition.

---

---
Generated by Claude Code Patch Reviewer