From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge_connector: Convert to atomic_create_state Date: Wed, 27 May 2026 14:30:53 +1000 Message-ID: In-Reply-To: <20260526-drm-mode-config-init-v6-19-852346394200@kernel.org> References: <20260526-drm-mode-config-init-v6-0-852346394200@kernel.org> <20260526-drm-mode-config-init-v6-19-852346394200@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Converts `drm_bridge_connector_reset()` to `drm_bridge_connector_create_sta= te()`. The new function calls `drm_atomic_helper_connector_create_state()` = and conditionally calls `__drm_atomic_helper_connector_hdmi_state_init()` i= f the bridge is HDMI. One observation: the old code called `drm_atomic_helper_connector_reset(con= nector)` which frees old state via `kfree(connector->state)` before allocat= ing new state. The new code has no state freeing =E2=80=94 this is correct = since `atomic_create_state` must not touch the object's state pointer, and = the `reset_with_create_state` wrapper in `drm_mode_config_reset()` handles = the old-state cleanup. The `.reset` is removed, so the comment about `drm_mode_config_reset()` fal= lback from patch 15 applies here too. Correct. --- Generated by Claude Code Patch Reviewer