From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: dw_hdmi_qp: Defer HPD IRQ enable until after connector setup Date: Thu, 04 Jun 2026 13:33:50 +1000 Message-ID: In-Reply-To: <20260602-dw-hdmi-qp-scramb-v7-19-445eb54ee1ed@collabora.com> References: <20260602-dw-hdmi-qp-scramb-v7-0-445eb54ee1ed@collabora.com> <20260602-dw-hdmi-qp-scramb-v7-19-445eb54ee1ed@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Dropping `IRQF_SHARED` in favor of `IRQF_NO_AUTOEN` is correct =E2=80=94 th= e IRQ has no other users. The `enable_irq()` at the end of `bind()` ensures= HPD is armed only after the full DRM pipeline is set up. --- Generated by Claude Code Patch Reviewer