public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: Change st-dma-fence.c to use kunit
Date: Tue, 03 Mar 2026 13:50:32 +1000	[thread overview]
Message-ID: <review-patch2-2-v1-0a349a394eff+14110-dmabuf_kunit_jgg@nvidia.com> (raw)
In-Reply-To: <2-v1-0a349a394eff+14110-dmabuf_kunit_jgg@nvidia.com>

Patch Review

Good conversion overall. The `num_online_cpus() < 2` skip in `test_race_signal_callback` is the right fix for the kunit.py single-CPU VM environment.

**Typo:** In `test_wait_timeout`:
```c
			kunit_mark_skipped(
				test, "Timer did not fire within on HZ!\n");
```
"within **on** HZ" should be "within **one** HZ". Also, the trailing `\n` is unnecessary in kunit messages.

**`dma_fence_suite_init` is arguably unnecessary:** The function only prints `sizeof(dma_fence)`:
```c
static int dma_fence_suite_init(struct kunit_suite *suite)
{
	pr_info("sizeof(dma_fence)=%zu\n", sizeof(struct dma_fence));
	return 0;
}
```
This doesn't set up any resources that the tests depend on. It's a minor informational message. Not wrong, but `suite_init` is normally used for resource initialization (as done correctly in patch 4 for the slab cache). If the pr_info is desired, it could also be placed in a test or simply dropped.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-03  3:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-01 18:57 [PATCH 0/5] Replace the dmabuf custom test framework with kunit Jason Gunthorpe
2026-03-01 18:57 ` [PATCH 1/5] dma-buf: Change st-dma-resv.c to use kunit Jason Gunthorpe
2026-03-03  3:50   ` Claude review: " Claude Code Review Bot
2026-03-01 18:57 ` [PATCH 2/5] dma-buf: Change st-dma-fence.c " Jason Gunthorpe
2026-03-03  3:50   ` Claude Code Review Bot [this message]
2026-03-01 18:57 ` [PATCH 3/5] dma-buf: Change st-dma-fence-unwrap.c " Jason Gunthorpe
2026-03-03  3:50   ` Claude review: " Claude Code Review Bot
2026-03-01 18:57 ` [PATCH 4/5] dma-buf: Change st-dma-fence-chain.c " Jason Gunthorpe
2026-03-03  3:50   ` Claude review: " Claude Code Review Bot
2026-03-01 18:57 ` [PATCH 5/5] dma-buf: Remove the old selftest Jason Gunthorpe
2026-03-03  3:50   ` Claude review: " Claude Code Review Bot
2026-03-02 11:43 ` [PATCH 0/5] Replace the dmabuf custom test framework with kunit Christian König
2026-03-02 13:01   ` Jason Gunthorpe
2026-03-02 13:58     ` Christian König
2026-03-03  3:50 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-2-v1-0a349a394eff+14110-dmabuf_kunit_jgg@nvidia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox