From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: Change st-dma-fence.c to use kunit Date: Tue, 03 Mar 2026 13:50:32 +1000 Message-ID: In-Reply-To: <2-v1-0a349a394eff+14110-dmabuf_kunit_jgg@nvidia.com> References: <0-v1-0a349a394eff+14110-dmabuf_kunit_jgg@nvidia.com> <2-v1-0a349a394eff+14110-dmabuf_kunit_jgg@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good conversion overall. The `num_online_cpus() < 2` skip in `test_race_signal_callback` is the right fix for the kunit.py single-CPU VM environment. **Typo:** In `test_wait_timeout`: ```c kunit_mark_skipped( test, "Timer did not fire within on HZ!\n"); ``` "within **on** HZ" should be "within **one** HZ". Also, the trailing `\n` is unnecessary in kunit messages. **`dma_fence_suite_init` is arguably unnecessary:** The function only prints `sizeof(dma_fence)`: ```c static int dma_fence_suite_init(struct kunit_suite *suite) { pr_info("sizeof(dma_fence)=%zu\n", sizeof(struct dma_fence)); return 0; } ``` This doesn't set up any resources that the tests depend on. It's a minor informational message. Not wrong, but `suite_init` is normally used for resource initialization (as done correctly in patch 4 for the slab cache). If the pr_info is desired, it could also be placed in a test or simply dropped. --- Generated by Claude Code Patch Reviewer