public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: panel-simple-dsi: add nt37700f compatible
Date: Wed, 11 Feb 2026 16:47:57 +1000	[thread overview]
Message-ID: <review-patch2-20260210023300.15785-3-mailingradian@gmail.com> (raw)
In-Reply-To: <20260210023300.15785-3-mailingradian@gmail.com>

Patch Review

**CRITICAL ISSUE - Wrong Binding File:**

```yaml
+        # Novatek NT37700F 1080x2160 AMOLED panel
+      - novatek,nt37700f
```

This adds NT37700F to `panel-simple-dsi.yaml`, which is for panels driven by standard DCS commands. However, examining Patch 3's driver reveals:

```c
mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00);
mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc0, 0x56);
mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xff, 0xaa, 0x55, 0xa5, 0x80);
```

These are vendor-specific register sequences, NOT standard DCS commands. The panel requires:
- Custom initialization sequences
- Custom backlight operations  
- Vendor-specific register access

**This panel needs its own binding document:**
`Documentation/devicetree/bindings/display/panel/novatek,nt37700f.yaml`

The binding should document required properties: reset-gpios, power-supply, port, and note the embedded backlight support.

**Rating:** NACK - Must create dedicated binding file, remove from panel-simple-dsi.yaml

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-02-11  6:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  2:32 [PATCH 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-10  2:32 ` [PATCH 1/6] dt-bindings: arm: qcom: document google, bonito-tianma board Richard Acayan
2026-02-10  9:12   ` Krzysztof Kozlowski
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 ` [PATCH 2/6] dt-bindings: panel-simple-dsi: add nt37700f compatible Richard Acayan
2026-02-10  9:12   ` Krzysztof Kozlowski
2026-02-11  6:47   ` Claude Code Review Bot [this message]
2026-02-10  2:32 ` [PATCH 3/6] drm/panel: Add Novatek/Tianma NT37700F panel Richard Acayan
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 ` [PATCH 4/6] arm64: dts: qcom: sdm670-google-sargo: add touchscreen and display labels Richard Acayan
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 ` [PATCH 5/6] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-12 10:30   ` [PATCH 5/6] " Konrad Dybcio
2026-02-10  2:33 ` [PATCH 6/6] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-02-10  9:10   ` Konrad Dybcio
2026-02-11 19:33     ` Richard Acayan
2026-02-12 10:29       ` Konrad Dybcio
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-11  6:47 ` Claude review: Support for the Pixel 3a XL with the Tianma panel Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260210023300.15785-3-mailingradian@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox