From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: panel-simple-dsi: add nt37700f compatible Date: Wed, 11 Feb 2026 16:47:57 +1000 Message-ID: In-Reply-To: <20260210023300.15785-3-mailingradian@gmail.com> References: <20260210023300.15785-1-mailingradian@gmail.com> <20260210023300.15785-3-mailingradian@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Patch Review **CRITICAL ISSUE - Wrong Binding File:** ```yaml + # Novatek NT37700F 1080x2160 AMOLED panel + - novatek,nt37700f ``` This adds NT37700F to `panel-simple-dsi.yaml`, which is for panels driven by standard DCS commands. However, examining Patch 3's driver reveals: ```c mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc0, 0x56); mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xff, 0xaa, 0x55, 0xa5, 0x80); ``` These are vendor-specific register sequences, NOT standard DCS commands. The panel requires: - Custom initialization sequences - Custom backlight operations - Vendor-specific register access **This panel needs its own binding document:** `Documentation/devicetree/bindings/display/panel/novatek,nt37700f.yaml` The binding should document required properties: reset-gpios, power-supply, port, and note the embedded backlight support. **Rating:** NACK - Must create dedicated binding file, remove from panel-simple-dsi.yaml --- --- Generated by Claude Code Patch Reviewer