public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ci: i915: cml: update runner tag
Date: Thu, 12 Feb 2026 15:48:41 +1000	[thread overview]
Message-ID: <review-patch2-20260210071138.2256773-3-vignesh.raman@collabora.com> (raw)
In-Reply-To: <20260210071138.2256773-3-vignesh.raman@collabora.com>

Patch Review

**Commit:** `156dc8e49612d`

Changes the CML (Comet Lake) i915 CI job from `asus-C436FA-Flip-hatch` to `acer-chromebox-cxi4-puff`, increasing parallel count from 2 to 5 to match the larger device pool. Also increases `i915:amly` parallel count from 2 to 3.

```yaml
-  parallel: 2
+  parallel: 5
   variables:
-    DEVICE_TYPE: asus-C436FA-Flip-hatch
+    DEVICE_TYPE: acer-chromebox-cxi4-puff
     GPU_VERSION: cml
-    RUNNER_TAG: mesa-ci-x86-64-lava-asus-C436FA-Flip-hatch
+    RUNNER_TAG: mesa-ci-x86-64-lava-acer-chromebox-cxi4-puff
```

**Analysis:** The commit message explains hatch has only 2 DUTs causing timeouts, while puff has 5 DUTs. Switching to puff and setting `parallel: 5` makes sense. The `GPU_VERSION: cml` is retained, confirming both devices have the same CML GPU. The amly parallel increase to 3 is mentioned in the commit message ("Also increase parallel count for amly jobs to 3").

**Note:** The i915-cml-flakes.txt still references "Board Name: asus-C436FA-Flip-hatch" for the `perf_pmu@most-busy-check-all` entry. This is slightly inconsistent since the actual CI will now run on puff, but flake entries are informational metadata and the test name is what matters for matching, not the board name comment. This is cosmetic and not a functional issue.

**Verdict:** No issues. The device switch is well-justified.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-12  5:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  7:11 [PATCH v2 0/5] drm/ci: add new jobs, uprev IGT and mesa Vignesh Raman
2026-02-10  7:11 ` [PATCH v2 1/5] drm/ci: reduce sm8350-hdk parallel jobs from 4 to 2 Vignesh Raman
2026-02-12  5:48   ` Claude review: " Claude Code Review Bot
2026-02-10  7:11 ` [PATCH v2 2/5] drm/ci: i915: cml: update runner tag Vignesh Raman
2026-02-12  5:48   ` Claude Code Review Bot [this message]
2026-02-10  7:11 ` [PATCH v2 3/5] drm/ci: uprev mesa Vignesh Raman
2026-02-10 21:07   ` Dmitry Baryshkov
2026-02-12  5:48   ` Claude review: " Claude Code Review Bot
2026-02-10  7:11 ` [PATCH v2 4/5] drm/ci: move qualcomm baremetal jobs to lava Vignesh Raman
2026-02-10 22:13   ` Dmitry Baryshkov
2026-02-12  5:48   ` Claude review: " Claude Code Review Bot
2026-02-10  7:11 ` [PATCH v2 5/5] drm/ci: add rk3588-rock-5b Vignesh Raman
2026-02-12  5:48   ` Claude review: " Claude Code Review Bot
2026-02-11  6:42 ` Claude review: drm/ci: add new jobs, uprev IGT and mesa Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260210071138.2256773-3-vignesh.raman@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox