From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use Date: Wed, 11 Feb 2026 16:37:15 +1000 Message-ID: In-Reply-To: <20260210071225.2566099-3-damon.ding@rock-chips.com> References: <20260210071225.2566099-1-damon.ding@rock-chips.com> <20260210071225.2566099-3-damon.ding@rock-chips.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Patch Review **Summary:** Generalizes i.MX-specific legacy bridge for use across platforms. Renames from `imx-legacy-bridge` to `of-display-mode-bridge`. **Code review:** ```c +struct drm_bridge *devm_drm_of_display_mode_bridge(struct device *dev, + struct device_node *np, + int type) ``` The API naming is consistent with DRM conventions (`devm_drm_` prefix). ```c + help + This is a DRM bridge implementation that uses of_get_drm_display_mode + to acquire display mode. + + It exists for compatibility with legacy display mode parsing, in order + to conform to the panel-bridge framework. ``` Good documentation of the compatibility purpose. **Concerns:** - The code is almost entirely unchanged (good for correctness) - Module authorship attribution changes from Sascha Hauer to Dmitry Baryshkov on the new file - verify this is intentional - The Kconfig help text properly explains this is for legacy compatibility **Verdict:** Well-executed code movement, authorship change needs verification. --- --- Generated by Claude Code Patch Reviewer