From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: clk: bcm: rpi: Add a comment about RPI_FIRMWARE_SET_CLOCK_STATE behavior Date: Sat, 14 Feb 2026 07:21:52 +1000 Message-ID: In-Reply-To: <20260213-v3d-power-management-v5-2-7a8b381eb379@igalia.com> References: <20260213-v3d-power-management-v5-0-7a8b381eb379@igalia.com> <20260213-v3d-power-management-v5-2-7a8b381eb379@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review > + /* > + * On some firmware versions, RPI_FIRMWARE_SET_CLOCK_STATE doesn't > + * actually power off the clock. To achieve meaningful power consumption > + * reduction, consumers need to set the clock rate to minimum before > + * disabling it. > + */ Documentation-only change. The comment is placed in `raspberrypi_fw_unprepare= ()`, which is the right location since this is where consumers would expect t= he clock to actually power off. No issues found. --- Generated by Claude Code Patch Reviewer