From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: r61307/r69328: convert to drm_connector_helper_get_modes_fixed
Date: Sun, 15 Feb 2026 20:24:18 +1000 [thread overview]
Message-ID: <review-patch2-20260215085140.20499-3-clamor95@gmail.com> (raw)
In-Reply-To: <20260215085140.20499-3-clamor95@gmail.com>
Patch Review
Replaces hand-rolled `get_modes` implementations with `drm_connector_helper_get_modes_fixed()`. Adds `select VIDEOMODE_HELPERS` to Kconfig and `#include <drm/drm_probe_helper.h>`.
The helper (`drm_probe_helper.c:1158`) performs the same operations:
- `drm_mode_duplicate()`
- `drm_mode_set_name()` (conditionally, if name is empty)
- ORs `DRM_MODE_TYPE_PREFERRED` onto `mode->type`
- Sets `display_info.width_mm/height_mm` from the mode
- `drm_mode_probed_add()`
The `.type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED` is moved into the static mode struct. The helper's `mode->type |= DRM_MODE_TYPE_PREFERRED` is idempotent since PREFERRED is already set. The helper returns 0 on failure instead of -ENOMEM, but `drm_panel_get_modes()` already clamps negative returns to 0.
No regressions.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-15 10:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 8:51 [PATCH v1 0/5] drm/panel: r61307/r69328: minor updates Svyatoslav Ryhel
2026-02-15 8:51 ` [PATCH v1 1/5] drm/panel: r61307: align with schema property Svyatoslav Ryhel
2026-02-15 10:24 ` Claude review: " Claude Code Review Bot
2026-02-15 8:51 ` [PATCH v1 2/5] drm/panel: r61307/r69328: convert to drm_connector_helper_get_modes_fixed Svyatoslav Ryhel
2026-02-15 10:24 ` Claude Code Review Bot [this message]
2026-02-15 8:51 ` [PATCH v1 3/5] drm/panel: r61307/r69328: remove redundant checks Svyatoslav Ryhel
2026-02-15 10:24 ` Claude review: " Claude Code Review Bot
2026-02-15 8:51 ` [PATCH v1 4/5] drm/panel: r61307/r69328: return accumulated errors Svyatoslav Ryhel
2026-02-15 10:24 ` Claude review: " Claude Code Review Bot
2026-02-15 8:51 ` [PATCH v1 5/5] drm/panel: r61307/r69328: convert to devm_mipi_dsi_attach Svyatoslav Ryhel
2026-02-15 10:24 ` Claude review: " Claude Code Review Bot
2026-02-15 9:01 ` Claude review: None Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260215085140.20499-3-clamor95@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox