From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: r61307/r69328: convert to drm_connector_helper_get_modes_fixed Date: Sun, 15 Feb 2026 20:24:18 +1000 Message-ID: In-Reply-To: <20260215085140.20499-3-clamor95@gmail.com> References: <20260215085140.20499-1-clamor95@gmail.com> <20260215085140.20499-3-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Replaces hand-rolled `get_modes` implementations with `drm_connector_helper_g= et_modes_fixed()`. Adds `select VIDEOMODE_HELPERS` to Kconfig and `#include <= drm/drm_probe_helper.h>`. The helper (`drm_probe_helper.c:1158`) performs the same operations: - `drm_mode_duplicate()`=20 - `drm_mode_set_name()` (conditionally, if name is empty) - ORs `DRM_MODE_TYPE_PREFERRED` onto `mode->type` - Sets `display_info.width_mm/height_mm` from the mode - `drm_mode_probed_add()` The `.type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED` is moved into = the static mode struct. The helper's `mode->type |=3D DRM_MODE_TYPE_PREFERRED= ` is idempotent since PREFERRED is already set. The helper returns 0 on failu= re instead of -ENOMEM, but `drm_panel_get_modes()` already clamps negative re= turns to 0. No regressions. --- Generated by Claude Code Patch Reviewer