From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: misc: fastrpc: Replace hardcoded ctxid mask with GENMASK
Date: Mon, 16 Feb 2026 08:26:14 +1000 [thread overview]
Message-ID: <review-patch2-20260215182136.3995111-3-ekansh.gupta@oss.qualcomm.com> (raw)
In-Reply-To: <20260215182136.3995111-3-ekansh.gupta@oss.qualcomm.com>
Patch Review
**Assessment: Good, straightforward cleanup**
This patch is a clean mechanical replacement of `0xFF0` with `GENMASK(11, 4)` and manual shift operations with `FIELD_PREP`/`FIELD_GET`. The semantics are preserved exactly:
- `ctx->ctxid = ret << 4` becomes `ctx->ctxid = FIELD_PREP(FASTRPC_CTXID_MASK, ret)` — equivalent for `GENMASK(11, 4)`.
- `idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4)` becomes `idr_remove(&cctx->ctx_idr, FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid))` — equivalent.
- `((rsp->ctx & FASTRPC_CTXID_MASK) >> 4)` becomes `FIELD_GET(FASTRPC_CTXID_MASK, rsp->ctx)` — equivalent.
Already has Reviewed-by from Konrad Dybcio.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-15 22:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 18:21 [PATCH v6 0/4] misc: fastrpc: Add polling mode support Ekansh Gupta
2026-02-15 18:21 ` [PATCH v6 1/4] misc: fastrpc: Move fdlist to invoke context structure Ekansh Gupta
2026-02-15 22:26 ` Claude review: " Claude Code Review Bot
2026-02-15 18:21 ` [PATCH v6 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Ekansh Gupta
2026-02-15 22:26 ` Claude Code Review Bot [this message]
2026-02-15 18:21 ` [PATCH v6 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Ekansh Gupta
2026-02-15 22:26 ` Claude review: " Claude Code Review Bot
2026-02-15 18:21 ` [PATCH v6 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Ekansh Gupta
2026-02-15 22:26 ` Claude review: " Claude Code Review Bot
2026-02-15 20:40 ` Claude review: misc: fastrpc: Add polling mode support Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260215182136.3995111-3-ekansh.gupta@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox