From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Date: Mon, 16 Feb 2026 08:26:14 +1000 Message-ID: In-Reply-To: <20260215182136.3995111-3-ekansh.gupta@oss.qualcomm.com> References: <20260215182136.3995111-1-ekansh.gupta@oss.qualcomm.com> <20260215182136.3995111-3-ekansh.gupta@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Assessment: Good, straightforward cleanup** This patch is a clean mechanical replacement of `0xFF0` with `GENMASK(11, 4)`= and manual shift operations with `FIELD_PREP`/`FIELD_GET`. The semantics are= preserved exactly: - `ctx->ctxid =3D ret << 4` becomes `ctx->ctxid =3D FIELD_PREP(FASTRPC_CTXID_= MASK, ret)` =E2=80=94 equivalent for `GENMASK(11, 4)`. - `idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4)` becomes `idr_remove(&cctx->ct= x_idr, FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid))` =E2=80=94 equivalent. - `((rsp->ctx & FASTRPC_CTXID_MASK) >> 4)` becomes `FIELD_GET(FASTRPC_CTXID_M= ASK, rsp->ctx)` =E2=80=94 equivalent. Already has Reviewed-by from Konrad Dybcio. --- Generated by Claude Code Patch Reviewer