From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: remove unnecessary Display impls Date: Tue, 17 Feb 2026 15:48:06 +1000 Message-ID: In-Reply-To: <20260217-nova-misc-v3-2-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> <20260217-nova-misc-v3-2-b4e2d45eafbc@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This removes hand-written `Display` implementations for `MsgFunction` and `SeqBufOpcode` in favor of their derived `Debug` impls. The format string in `send_command` is updated from `{}` to `{:?}` to match. > - "GSP RPC: send: seq# {}, function={}, length=0x{:x}\n", > + "GSP RPC: send: seq# {}, function={:?}, length=0x{:x}\n", The `fmt` import is also removed from the `use kernel` block. Clean and straightforward. No issues found. --- Generated by Claude Code Patch Reviewer