From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel: ethosu: Fix NPU_OP_ELEMENTWISE validation with scalar
Date: Thu, 19 Feb 2026 09:57:31 +1000 [thread overview]
Message-ID: <review-patch2-20260218-ethos-fixes-v1-2-be3fa3ea9a30@kernel.org> (raw)
In-Reply-To: <20260218-ethos-fixes-v1-2-be3fa3ea9a30@kernel.org>
Patch Review
The change correctly differentiates the u65 and u85 scalar detection for elementwise operations:
> + use_scale = ethosu_is_u65(edev) ?
> + (st.ifm2.broadcast & 0x80) :
> + (st.ifm2.broadcast == 8);
> + use_ifm2 = !(use_scale || (param == 5) ||
> (param == 6) || (param == 7) || (param == 0x24));
On the u65, scalar mode is indicated by bit 7 of the IFM2_BROADCAST register, while on the u85 the existing check `broadcast == 8` (i.e., bits 3:0 equal to 8) applies. The commit message explains the hardware difference clearly. The logic substitution from `!(A || B || C)` to `!(use_scale || B || C)` preserves the original structure correctly. No issues found.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-18 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 22:21 [PATCH 0/3] accel: ethosu: Runtime PM refcounting and cmd stream validation fixes Rob Herring (Arm)
2026-02-18 22:21 ` [PATCH 1/3] accel: ethosu: Fix job submit error clean-up refcount underflows Rob Herring (Arm)
2026-02-18 23:57 ` Claude review: " Claude Code Review Bot
2026-02-18 22:21 ` [PATCH 2/3] accel: ethosu: Fix NPU_OP_ELEMENTWISE validation with scalar Rob Herring (Arm)
2026-02-18 23:57 ` Claude Code Review Bot [this message]
2026-02-18 22:21 ` [PATCH 3/3] accel: ethosu: Handle possible underflow in IFM size calculations Rob Herring (Arm)
2026-02-18 23:57 ` Claude review: " Claude Code Review Bot
2026-02-18 23:57 ` Claude review: accel: ethosu: Runtime PM refcounting and cmd stream validation fixes Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260218-ethos-fixes-v1-2-be3fa3ea9a30@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox