From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel: ethosu: Fix NPU_OP_ELEMENTWISE validation with scalar Date: Thu, 19 Feb 2026 09:57:31 +1000 Message-ID: In-Reply-To: <20260218-ethos-fixes-v1-2-be3fa3ea9a30@kernel.org> References: <20260218-ethos-fixes-v1-0-be3fa3ea9a30@kernel.org> <20260218-ethos-fixes-v1-2-be3fa3ea9a30@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The change correctly differentiates the u65 and u85 scalar detection for elementwise operations: > + use_scale = ethosu_is_u65(edev) ? > + (st.ifm2.broadcast & 0x80) : > + (st.ifm2.broadcast == 8); > + use_ifm2 = !(use_scale || (param == 5) || > (param == 6) || (param == 7) || (param == 0x24)); On the u65, scalar mode is indicated by bit 7 of the IFM2_BROADCAST register, while on the u85 the existing check `broadcast == 8` (i.e., bits 3:0 equal to 8) applies. The commit message explains the hardware difference clearly. The logic substitution from `!(A || B || C)` to `!(use_scale || B || C)` preserves the original structure correctly. No issues found. --- Generated by Claude Code Patch Reviewer