public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: rename `AlwaysRefCounted` to `RefCounted`.
Date: Mon, 23 Feb 2026 06:08:50 +1000	[thread overview]
Message-ID: <review-patch2-20260220-unique-ref-v15-2-893ed86b06cc@kernel.org> (raw)
In-Reply-To: <20260220-unique-ref-v15-2-893ed86b06cc@kernel.org>

Patch Review

This is a large mechanical rename across 20 files, splitting the old `AlwaysRefCounted` into `RefCounted` (the trait with `inc_ref`/`dec_ref`) and a new marker `AlwaysRefCounted: RefCounted` that permits `&T -> ARef<T>`.

> +/// Implementers must ensure that no safety invariants are violated by upgrading an `&T` to an
> +/// [`ARef<T>`]. In particular that implies [`AlwaysRefCounted`] and [`crate::types::Ownable`]
> +/// cannot be implemented for the same type, as this would allow violating the uniqueness guarantee
> +/// of [`crate::types::Owned<T>`] by dereferencing it into an `&T` and obtaining an [`ARef`] from
> +/// that.
> +pub unsafe trait AlwaysRefCounted: RefCounted {}

The safety documentation here is clear and the rationale for the split is well explained. The mechanical changes across all the driver files look correct -- each existing `AlwaysRefCounted` impl is split into `RefCounted` (with the actual `inc_ref`/`dec_ref`) plus an empty `AlwaysRefCounted` marker.

> +// SAFETY: We currently do not implement `Ownable`, thus it is okay to obtain an `ARef<Request>`
> +// from a `&Request` (but this will change in the future).
> +unsafe impl<T: Operations> AlwaysRefCounted for Request<T> {}

The "but this will change in the future" note is a good heads-up for downstream work.

No issues found in this patch.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-22 20:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-20  9:51 [PATCH v15 0/9] rust: add `Ownable` trait and `Owned` type Andreas Hindborg
2026-02-20  9:51 ` [PATCH v15 1/9] rust: types: Add Ownable/Owned types Andreas Hindborg
2026-02-20 10:35   ` Alice Ryhl
2026-02-22 20:08   ` Claude review: " Claude Code Review Bot
2026-02-20  9:51 ` [PATCH v15 2/9] rust: rename `AlwaysRefCounted` to `RefCounted` Andreas Hindborg
2026-02-22 20:08   ` Claude Code Review Bot [this message]
2026-02-20  9:51 ` [PATCH v15 3/9] rust: Add missing SAFETY documentation for `ARef` example Andreas Hindborg
2026-02-20 10:49   ` Alice Ryhl
2026-02-22 20:08   ` Claude review: " Claude Code Review Bot
2026-02-20  9:51 ` [PATCH v15 4/9] rust: aref: update formatting of use statements Andreas Hindborg
2026-02-22 20:08   ` Claude review: " Claude Code Review Bot
2026-02-20  9:51 ` [PATCH v15 5/9] rust: Add `OwnableRefCounted` Andreas Hindborg
2026-02-22 20:08   ` Claude review: " Claude Code Review Bot
2026-02-20  9:51 ` [PATCH v15 6/9] rust: page: update formatting of `use` statements Andreas Hindborg
2026-02-22 20:08   ` Claude review: " Claude Code Review Bot
2026-02-20  9:51 ` [PATCH v15 7/9] rust: page: convert to `Ownable` Andreas Hindborg
2026-02-22 20:08   ` Claude review: " Claude Code Review Bot
2026-02-20  9:51 ` [PATCH v15 8/9] rust: implement `ForeignOwnable` for `Owned` Andreas Hindborg
2026-02-22 20:08   ` Claude review: " Claude Code Review Bot
2026-02-20  9:51 ` [PATCH v15 9/9] rust: page: add `from_raw()` Andreas Hindborg
2026-02-20 10:49   ` Alice Ryhl
2026-02-20 17:33   ` Miguel Ojeda
2026-02-20 17:50     ` Tamir Duberstein
2026-02-22 20:08   ` Claude review: " Claude Code Review Bot
2026-02-22 20:08 ` Claude review: rust: add `Ownable` trait and `Owned` type Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-02-24 11:17 [PATCH v16 00/10] " Andreas Hindborg
2026-02-24 11:17 ` [PATCH v16 03/10] rust: rename `AlwaysRefCounted` to `RefCounted` Andreas Hindborg
2026-02-27  5:11   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260220-unique-ref-v15-2-893ed86b06cc@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox