From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: tyr: remove impl Send/Sync for TyrData
Date: Tue, 24 Feb 2026 10:11:36 +1000
Message-ID: <review-patch2-20260223-clk-send-sync-v5-2-181bf2f35652@google.com>
In-Reply-To: <20260223-clk-send-sync-v5-2-181bf2f35652@google.com>
References: <20260223-clk-send-sync-v5-0-181bf2f35652@google.com> <20260223-clk-send-sync-v5-2-181bf2f35652@google.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

> -// Both `Clk` and `Regulator` do not implement `Send` or `Sync`, but they
> -// should. There are patches on the mailing list to address this, but they have
> -// not landed yet.
> -//
> -// For now, add this workaround so that this patch compiles with the promise
> -// that it will be removed in a future patch.
> -//
> -// SAFETY: This will be removed in a future patch.
> -unsafe impl Send for TyrData {}
> -// SAFETY: This will be removed in a future patch.
> -unsafe impl Sync for TyrData {}

Removal is correct. After patch 1, `TyrData`'s fields all auto-derive `Send`/`Sync`: `ARef<platform::Device>` is `Send`+`Sync`, `Mutex<Clocks>` is `Send`+`Sync` (where `Clocks` contains `Clk` and `OptionalClk`, now both `Send`+`Sync`), `Mutex<Regulators>` is `Send`+`Sync` (where `Regulator<T>` already has `Send`+`Sync` per commit 9a200cbdb543), and `GpuInfo` wraps a plain data struct. The commit message correctly explains that the `Regulator` case was already resolved in mainline.

No issues found.

---
Generated by Claude Code Patch Reviewer