public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge
Date: Tue, 24 Feb 2026 10:21:11 +1000	[thread overview]
Message-ID: <review-patch2-20260223-upstream-6162-v1-2-ebcc66ccb1fe@ite.com.tw> (raw)
In-Reply-To: <20260223-upstream-6162-v1-2-ebcc66ccb1fe@ite.com.tw>

Patch Review

> +  For audio, the IT61620 supports up to 8-channel LPCM via I2S

Minor: "IT61620" should be "IT6162" -- appears to be a typo in the description.

> +    required:
> +      - port@1

Only `port@1` (the second DSI input) is required, not `port@0`. This means a board could have only the second DSI port connected without the first, which seems odd. Should `port@0` also be required, or at least have a note explaining why only port@1 is mandatory? Looking at the driver, it iterates ports 0 and 1 and enables whichever are present, so requiring only port@1 seems like an arbitrary choice that should at least be documented.

The binding is missing several vendor-specific properties used by the driver:
- `ite,mipi-dsi-phy-pn-swap`
- `ite,mipi-dsi-phy-link-swap`
- `ite,mipi-dsi-mode-video-sync-pulse`
- `ite,mipi-dsi-clock-non-continous`
- `ite,hdcp-version`

With `unevaluatedProperties: false`, any DT using these undocumented properties would fail schema validation.

The supply properties (`ivdd-supply`, `ovdd-supply`, `ovdd1833-supply`) are documented but not listed as required, and the driver silently ignores their absence. This is fine if they're truly optional, but the example includes all three which suggests they are normally needed.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-24  0:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23  9:20 [PATCH 0/3] Add ITE IT6162 MIPI DSI to HDMI bridge driver Hermes Wu via B4 Relay
2026-02-23  9:20 ` [PATCH 1/3] drm/bridge: " Hermes Wu via B4 Relay
2026-02-24  0:21   ` Claude review: " Claude Code Review Bot
2026-02-23  9:20 ` [PATCH 2/3] dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge Hermes Wu via B4 Relay
2026-02-24  0:21   ` Claude Code Review Bot [this message]
2026-02-23  9:20 ` [PATCH 3/3] MAINTAINERS: Add entry for ITE IT6162 MIPI DSI to HDMI bridge driver Hermes Wu via B4 Relay
2026-02-24  0:21   ` Claude review: " Claude Code Review Bot
2026-02-24  0:21 ` Claude review: Add " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-09  9:42 [PATCH v2 0/2] " Hermes Wu via B4 Relay
2026-03-09  9:42 ` [PATCH v2 1/2] dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge Hermes Wu via B4 Relay
2026-03-10  2:31   ` Claude review: " Claude Code Review Bot
2026-03-13  6:15 [PATCH v3 0/2] Add ITE IT6162 MIPI DSI to HDMI bridge driver Hermes Wu via B4 Relay
2026-03-13  6:16 ` [PATCH v3 1/2] dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge Hermes Wu via B4 Relay
2026-03-13 21:27   ` Claude review: " Claude Code Review Bot
2026-03-19  6:37 [PATCH v4 0/2] Add ITE IT6162 MIPI DSI to HDMI bridge driver Hermes Wu via B4 Relay
2026-03-19  6:37 ` [PATCH v4 1/2] dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge Hermes Wu via B4 Relay
2026-03-21 18:39   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260223-upstream-6162-v1-2-ebcc66ccb1fe@ite.com.tw \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox