From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge Date: Tue, 24 Feb 2026 10:21:11 +1000 Message-ID: In-Reply-To: <20260223-upstream-6162-v1-2-ebcc66ccb1fe@ite.com.tw> References: <20260223-upstream-6162-v1-0-ebcc66ccb1fe@ite.com.tw> <20260223-upstream-6162-v1-2-ebcc66ccb1fe@ite.com.tw> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review > + For audio, the IT61620 supports up to 8-channel LPCM via I2S Minor: "IT61620" should be "IT6162" -- appears to be a typo in the description. > + required: > + - port@1 Only `port@1` (the second DSI input) is required, not `port@0`. This means a board could have only the second DSI port connected without the first, which seems odd. Should `port@0` also be required, or at least have a note explaining why only port@1 is mandatory? Looking at the driver, it iterates ports 0 and 1 and enables whichever are present, so requiring only port@1 seems like an arbitrary choice that should at least be documented. The binding is missing several vendor-specific properties used by the driver: - `ite,mipi-dsi-phy-pn-swap` - `ite,mipi-dsi-phy-link-swap` - `ite,mipi-dsi-mode-video-sync-pulse` - `ite,mipi-dsi-clock-non-continous` - `ite,hdcp-version` With `unevaluatedProperties: false`, any DT using these undocumented properties would fail schema validation. The supply properties (`ivdd-supply`, `ovdd-supply`, `ovdd1833-supply`) are documented but not listed as required, and the driver silently ignores their absence. This is fine if they're truly optional, but the example includes all three which suggests they are normally needed. --- Generated by Claude Code Patch Reviewer