From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: ARM: tegra: transformers: add connector node Date: Tue, 24 Feb 2026 10:34:48 +1000 Message-ID: In-Reply-To: <20260223065500.13357-3-clamor95@gmail.com> References: <20260223065500.13357-1-clamor95@gmail.com> <20260223065500.13357-3-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review > - nvidia,hpd-gpio = <&gpio TEGRA_GPIO(N, 7) GPIO_ACTIVE_HIGH>; > - nvidia,ddc-i2c-bus = <&hdmi_ddc>; > + port { > + hdmi_out: endpoint { > + remote-endpoint = <&connector_in>; > + }; > + }; The legacy properties are removed and replaced with an OF graph port endpoint. This satisfies the `port` clause in the `anyOf` from patch 1. > + connector { > + compatible = "hdmi-connector"; > + type = "d"; > + > + hpd-gpios = <&gpio TEGRA_GPIO(N, 7) GPIO_ACTIVE_HIGH>; > + ddc-i2c-bus = <&hdmi_ddc>; > + > + port { > + connector_in: endpoint { > + remote-endpoint = <&hdmi_out>; > + }; > + }; > + }; The connector node looks correct. Type `"d"` is micro HDMI, which matches the cover letter's description of a micro-HDMI connector. The `hpd-gpios` and `ddc-i2c-bus` properties are both valid per the `hdmi-connector` binding, and the HPD GPIO specification is carried over from its previous location in the HDMI node. The OF graph endpoints are properly cross-referenced. Minor observation: the subject says "transformers" (plural) but this patch only modifies `tegra30-asus-tf600t.dts`. The Tested-by tags reference three different Transformer models (TF600T, TF101, TF201), suggesting similar DTS changes may come for those boards in a separate series. The subject could be more precise (e.g., "tegra: tf600t: add connector node"), but this is a trivial nit. No correctness issues found in this patch. --- Generated by Claude Code Patch Reviewer