From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/omapdrm: Switch private_obj initialization to atomic_create_state Date: Fri, 27 Feb 2026 15:05:37 +1000 Message-ID: In-Reply-To: <20260224-drm-private-obj-reset-v5-2-5a72f8ec9934@kernel.org> References: <20260224-drm-private-obj-reset-v5-0-5a72f8ec9934@kernel.org> <20260224-drm-private-obj-reset-v5-2-5a72f8ec9934@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Commit message**: Clear and well-written. **Code review**: The new `omap_global_atomic_create_state()` is clean and correct: ```c static struct drm_private_state * omap_global_atomic_create_state(struct drm_private_obj *obj) { struct omap_global_state *state; state = kzalloc_obj(*state); if (!state) return ERR_PTR(-ENOMEM); __drm_atomic_helper_private_obj_create_state(obj, &state->base); return &state->base; } ``` Simple and follows the pattern correctly. Since `omap_global_state` has no additional resources to initialize (just `kzalloc` is sufficient), this is the minimal correct implementation. **Same issue: Missing return value check:** ```c drm_atomic_private_obj_init(dev, &priv->glob_obj, NULL, &omap_global_state_funcs); return 0; ``` This should propagate the return value of `drm_atomic_private_obj_init()` instead of unconditionally returning 0. --- --- Generated by Claude Code Patch Reviewer