public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: gpu: img: Add J721e SoC specific compatible
Date: Fri, 27 Feb 2026 14:48:58 +1000	[thread overview]
Message-ID: <review-patch2-20260224-gpu_dts-v1-2-cc5ddffe140c@ti.com> (raw)
In-Reply-To: <20260224-gpu_dts-v1-2-cc5ddffe140c@ti.com>

Patch Review

**Author:** Antonios Christidis

Adds `ti,j721e-gpu` with `img,img-ge8430` to the PowerVR Rogue binding.

**Missing blank line:** The diff removes the blank line that separates the BXS-4-64 block from the legacy compatible block comment:

```yaml
-
+      - items:
+          - enum:
+              - ti,j721e-gpu
+          - const: img,img-ge8430
+          - const: img,img-rogue
       # This legacy combination of compatible strings was introduced early on
```

The original blank line before `# This legacy combination` acted as a visual separator. A blank line should be added after the new block to maintain readability:

```yaml
+      - items:
+          - enum:
+              - ti,j721e-gpu
+          - const: img,img-ge8430
+          - const: img,img-rogue
+
       # This legacy combination of compatible strings was introduced early on
```

**The allOf addition looks correct:**

```yaml
              - ti,am62-gpu
              - ti,am62p-gpu
              - ti,j721s2-gpu
+              - ti,j721e-gpu
```

This adds `ti,j721e-gpu` to the list of compatibles that have the single-clock constraint, which is correct.

**Question:** Does the `img,img-ge8430` GPU identifier need any driver-side changes to be recognized? If the driver currently doesn't handle this GPU ID, a driver patch may be needed in this series as well.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-02-27  4:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 18:09 [PATCH 0/5] drm/imagination: add support for j721e,j784s4,j722s,am62p Antonios Christidis
2026-02-24 18:09 ` [PATCH 1/5] arm64: dts: ti: k3-j721e: Add GPU node Antonios Christidis
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-24 18:09 ` [PATCH 2/5] dt-bindings: gpu: img: Add J721e SoC specific compatible Antonios Christidis
2026-02-24 23:09   ` Andrew Davis
2026-02-25 11:06   ` Krzysztof Kozlowski
2026-02-27  4:48   ` Claude Code Review Bot [this message]
2026-02-24 18:09 ` [PATCH 3/5] arm64: dts: ti: k3-j784s4: Add GPU node Antonios Christidis
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-24 18:09 ` [PATCH 4/5] arm64: dts: ti: add " a-christidis
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-24 18:09 ` [PATCH 5/5] clk: keystone: don't cache clock rate a-christidis
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-25  1:05 ` [PATCH 0/5] drm/imagination: add support for j721e,j784s4,j722s,am62p Nishanth Menon
2026-02-27  4:48 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260224-gpu_dts-v1-2-cc5ddffe140c@ti.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox