From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: gpu: img: Add J721e SoC specific compatible Date: Fri, 27 Feb 2026 14:48:58 +1000 Message-ID: In-Reply-To: <20260224-gpu_dts-v1-2-cc5ddffe140c@ti.com> References: <20260224-gpu_dts-v1-0-cc5ddffe140c@ti.com> <20260224-gpu_dts-v1-2-cc5ddffe140c@ti.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Author:** Antonios Christidis Adds `ti,j721e-gpu` with `img,img-ge8430` to the PowerVR Rogue binding. **Missing blank line:** The diff removes the blank line that separates the BXS-4-64 block from the legacy compatible block comment: ```yaml - + - items: + - enum: + - ti,j721e-gpu + - const: img,img-ge8430 + - const: img,img-rogue # This legacy combination of compatible strings was introduced early on ``` The original blank line before `# This legacy combination` acted as a visual separator. A blank line should be added after the new block to maintain readability: ```yaml + - items: + - enum: + - ti,j721e-gpu + - const: img,img-ge8430 + - const: img,img-rogue + # This legacy combination of compatible strings was introduced early on ``` **The allOf addition looks correct:** ```yaml - ti,am62-gpu - ti,am62p-gpu - ti,j721s2-gpu + - ti,j721e-gpu ``` This adds `ti,j721e-gpu` to the list of compatibles that have the single-clock constraint, which is correct. **Question:** Does the `img,img-ge8430` GPU identifier need any driver-side changes to be recognized? If the driver currently doesn't handle this GPU ID, a driver patch may be needed in this series as well. --- --- Generated by Claude Code Patch Reviewer