public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: defio: Keep module reference from VMAs
Date: Fri, 27 Feb 2026 15:29:26 +1000	[thread overview]
Message-ID: <review-patch2-20260224082657.207284-3-tzimmermann@suse.de> (raw)
In-Reply-To: <20260224082657.207284-3-tzimmermann@suse.de>

Patch Review

Short and correct. Prevents the fbdev core module from being unloaded while userspace VMAs exist.

```c
static void fb_deferred_io_vm_open(struct vm_area_struct *vma)
{
	struct fb_deferred_io_state *fbdefio_state = vma->vm_private_data;

	WARN_ON_ONCE(!try_module_get(THIS_MODULE));
	fb_deferred_io_state_get(fbdefio_state);
}
```

The `WARN_ON_ONCE` around `try_module_get` in `vm_open` is appropriate — `vm_open` is called during VMA duplication (e.g., fork) and cannot fail, so warning is the best we can do if the module is somehow being unloaded concurrently.

```c
static void fb_deferred_io_vm_close(struct vm_area_struct *vma)
{
	struct fb_deferred_io_state *fbdefio_state = vma->vm_private_data;

	fb_deferred_io_state_put(fbdefio_state);
	module_put(THIS_MODULE);
}
```

The ordering in `vm_close` is correct: release the state reference (which may call into module code via `fb_deferred_io_state_release`) *before* dropping the module reference.

In `fb_deferred_io_mmap`:

```c
if (!try_module_get(THIS_MODULE))
	return -EINVAL;
```

This correctly guards the initial mmap. No issues with this patch.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-27  5:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24  8:25 [PATCH v2 0/4] fbdev: defio: Protect against device/module removal Thomas Zimmermann
2026-02-24  8:25 ` [PATCH v2 1/4] fbdev: defio: Disconnect deferred I/O from the lifetime of struct fb_info Thomas Zimmermann
2026-02-27  5:29   ` Claude review: " Claude Code Review Bot
2026-02-24  8:25 ` [PATCH v2 2/4] fbdev: defio: Keep module reference from VMAs Thomas Zimmermann
2026-02-27  5:29   ` Claude Code Review Bot [this message]
2026-02-24  8:25 ` [PATCH v2 3/4] fbdev: defio: Move variable state into struct fb_deferred_io_state Thomas Zimmermann
2026-02-27  5:29   ` Claude review: " Claude Code Review Bot
2026-02-24  8:25 ` [PATCH v2 4/4] fbdev: defio: Move pageref array to " Thomas Zimmermann
2026-02-27  5:29   ` Claude review: " Claude Code Review Bot
2026-02-24 22:02 ` [PATCH v2 0/4] fbdev: defio: Protect against device/module removal Helge Deller
2026-02-27  5:29 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260224082657.207284-3-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox