From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: cgroup/dmem: Add dmem_cgroup_common_ancestor helper
Date: Fri, 27 Feb 2026 13:36:28 +1000 [thread overview]
Message-ID: <review-patch2-20260225-dmemcg-aggressive-protect-v4-2-de847ab35184@gmx.de> (raw)
In-Reply-To: <20260225-dmemcg-aggressive-protect-v4-2-de847ab35184@gmx.de>
Patch Review
The implementation is correct. The O(n*m) nested loop algorithm is fine given cgroup tree depths are typically very shallow (single digits).
**Doc typo**: The `@b` parameter documentation says "First pool" - should be "Second pool":
```c
+ * @a: First pool to find the common ancestor of.
+ * @b: First pool to find the common ancestor of.
```
Should be:
```c
+ * @b: Second pool to find the common ancestor of.
```
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 3:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 12:10 [PATCH v4 0/6] cgroup/dmem,drm/ttm: Improve protection in contended cases Natalie Vock
2026-02-25 12:10 ` [PATCH v4 1/6] cgroup/dmem: Add queries for protection values Natalie Vock
2026-02-27 3:36 ` Claude review: " Claude Code Review Bot
2026-02-25 12:10 ` [PATCH v4 2/6] cgroup/dmem: Add dmem_cgroup_common_ancestor helper Natalie Vock
2026-02-25 17:16 ` Tejun Heo
2026-02-27 3:36 ` Claude Code Review Bot [this message]
2026-02-25 12:10 ` [PATCH v4 3/6] drm/ttm: Extract code for attempting allocation in a place Natalie Vock
2026-02-25 15:18 ` Tvrtko Ursulin
2026-02-25 15:27 ` Tvrtko Ursulin
2026-02-26 8:56 ` Tvrtko Ursulin
2026-02-27 3:36 ` Claude review: " Claude Code Review Bot
2026-02-25 12:10 ` [PATCH v4 4/6] drm/ttm: Split cgroup charge and resource allocation Natalie Vock
2026-02-25 15:33 ` Tvrtko Ursulin
2026-02-25 16:01 ` Tvrtko Ursulin
2026-02-27 3:36 ` Claude review: " Claude Code Review Bot
2026-02-25 12:10 ` [PATCH v4 5/6] drm/ttm: Be more aggressive when allocating below protection limit Natalie Vock
2026-02-27 3:36 ` Claude review: " Claude Code Review Bot
2026-02-25 12:10 ` [PATCH v4 6/6] drm/ttm: Use common ancestor of evictor and evictee as limit pool Natalie Vock
2026-02-27 3:36 ` Claude review: " Claude Code Review Bot
2026-02-27 3:36 ` Claude review: cgroup/dmem,drm/ttm: Improve protection in contended cases Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260225-dmemcg-aggressive-protect-v4-2-de847ab35184@gmx.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox