public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: lemans-ride: Enable mdss1 display Port
Date: Fri, 27 Feb 2026 12:26:29 +1000	[thread overview]
Message-ID: <review-patch2-20260226111322.250176-3-quic_mkuntuma@quicinc.com> (raw)
In-Reply-To: <20260226111322.250176-3-quic_mkuntuma@quicinc.com>

Patch Review

This patch enables the mdss1 subsystem on the lemans-ride board, adding DP connectors and configuring the PHY power supplies and hot-plug-detect pins.

**Connector definitions (correct)**

```
+	dp2-connector {
+		compatible = "dp-connector";
+		label = "eDP2";
+		type = "full-size";
```

The naming (dp2/dp3, labeled eDP2/eDP3) and `type = "full-size"` follow the existing dp0/dp1 connectors exactly.

**DP output configuration (correct)**

```
+&mdss1_dp0_out {
+	data-lanes = <0 1 2 3>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+	remote-endpoint = <&dp2_connector_in>;
+};
```

4 data lanes and link frequencies matching the existing mdss0 DP outputs.

**PHY power supplies (correct)**

```
+&mdss1_dp0_phy {
+	vdda-phy-supply = <&vreg_l1c>;
+	vdda-pll-supply = <&vreg_l4a>;
+
+	status = "okay";
+};
```

Same supplies as the existing mdss0 DP PHYs in this board file.

**Hot-plug-detect pinctrl (looks reasonable)**

```
+	dp2_hot_plug_det: dp2-hot-plug-det-state {
+		pins = "gpio104";
+		function = "edp2_hot";
+		bias-disable;
+	};
+
+	dp3_hot_plug_det: dp3-hot-plug-det-state {
+		pins = "gpio103";
+		function = "edp3_hot";
+		bias-disable;
+	};
```

Uses `edp2_hot`/`edp3_hot` functions on gpio104/gpio103, consistent with the existing `edp0_hot`/`edp1_hot` pattern. The `bias-disable` setting matches the existing HPD pins.

**No issues found in this patch.** It's a clean board-level enablement that follows established patterns.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-02-27  2:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 11:13 [PATCH v4 0/2] Enable mdss1 Display Port for Qualcomm lemans-ride platform Mani Chandana Ballary Kuntumalla
2026-02-26 11:13 ` [PATCH v4 1/2] arm64: dts: qcom: lemans: add mdss1 display device nodes Mani Chandana Ballary Kuntumalla
2026-02-26 14:43   ` Konrad Dybcio
2026-02-27  2:26   ` Claude review: " Claude Code Review Bot
2026-02-26 11:13 ` [PATCH v4 2/2] arm64: dts: qcom: lemans-ride: Enable mdss1 display Port Mani Chandana Ballary Kuntumalla
2026-02-26 14:37   ` Konrad Dybcio
2026-02-27  2:26   ` Claude Code Review Bot [this message]
2026-02-27  2:26 ` Claude review: Enable mdss1 Display Port for Qualcomm lemans-ride platform Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260226111322.250176-3-quic_mkuntuma@quicinc.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox