From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: lemans-ride: Enable mdss1 display Port Date: Fri, 27 Feb 2026 12:26:29 +1000 Message-ID: In-Reply-To: <20260226111322.250176-3-quic_mkuntuma@quicinc.com> References: <20260226111322.250176-1-quic_mkuntuma@quicinc.com> <20260226111322.250176-3-quic_mkuntuma@quicinc.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch enables the mdss1 subsystem on the lemans-ride board, adding DP connectors and configuring the PHY power supplies and hot-plug-detect pins. **Connector definitions (correct)** ``` + dp2-connector { + compatible = "dp-connector"; + label = "eDP2"; + type = "full-size"; ``` The naming (dp2/dp3, labeled eDP2/eDP3) and `type = "full-size"` follow the existing dp0/dp1 connectors exactly. **DP output configuration (correct)** ``` +&mdss1_dp0_out { + data-lanes = <0 1 2 3>; + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>; + remote-endpoint = <&dp2_connector_in>; +}; ``` 4 data lanes and link frequencies matching the existing mdss0 DP outputs. **PHY power supplies (correct)** ``` +&mdss1_dp0_phy { + vdda-phy-supply = <&vreg_l1c>; + vdda-pll-supply = <&vreg_l4a>; + + status = "okay"; +}; ``` Same supplies as the existing mdss0 DP PHYs in this board file. **Hot-plug-detect pinctrl (looks reasonable)** ``` + dp2_hot_plug_det: dp2-hot-plug-det-state { + pins = "gpio104"; + function = "edp2_hot"; + bias-disable; + }; + + dp3_hot_plug_det: dp3-hot-plug-det-state { + pins = "gpio103"; + function = "edp3_hot"; + bias-disable; + }; ``` Uses `edp2_hot`/`edp3_hot` functions on gpio104/gpio103, consistent with the existing `edp0_hot`/`edp1_hot` pattern. The `bias-disable` setting matches the existing HPD pins. **No issues found in this patch.** It's a clean board-level enablement that follows established patterns. --- Generated by Claude Code Patch Reviewer